Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: prevent a lock file from being created #65359

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Sep 15, 2024

What?

Composer 1.10.0 introduced a lock config option, which, when set to false will prevent a composer.lock file from being created and will ignore it when one exists.

This is a useful option for packages like Gutenberg where the lock file has no meaning.

It also makes life more straight-forward for contributors as they don't have to remember that for this repo they should use composer update instead of composer install. Both will now work the same.

Refs:
https://getcomposer.org/doc/06-config.md#lock

Composer 1.10.0 introduced a `lock` config option, which, when set to `false` will prevent a `composer.lock` file from being created and will ignore it when one exists.

This is a useful option for packages like Gutenberg where the `lock` file has no meaning.

It also makes life more straight-forward for contributors as they don't have to remember that for this repo they should use `composer update` instead of `composer install`. Both will now work the same.

Refs:
https://getcomposer.org/doc/06-config.md#lock
@jrfnl jrfnl requested a review from desrosj September 15, 2024 16:50
Copy link

github-actions bot commented Sep 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jrfnl <[email protected]>
Co-authored-by: desrosj <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jrfnl jrfnl added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 15, 2024
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also matches the current configuration in WordPress/wordpress-develop. Seems sensible to me.

@desrosj desrosj merged commit f9aa29a into trunk Sep 26, 2024
65 of 66 checks passed
@desrosj desrosj deleted the fix/composer-no-lock branch September 26, 2024 16:48
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants