-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move duplicateTemplatePart
action to the @wordpress/fields
package
#65390
Merged
Merged
Changes from 50 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
67ff043
Migrate store and actions from editor package to fields package
gigitux a71e726
fix documentation
gigitux 0141d8c
fix import
gigitux f21a974
remove duplicate code
gigitux 7063ee8
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 644dab1
update package-lock
gigitux 3616964
refactor PR
gigitux f7f1d4d
fix mobile build
gigitux ae0efeb
update package.json
gigitux 4356a42
migrate actions to @wordpress/fields package
gigitux bf1462a
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 63adf35
reduce change
gigitux c938a15
register new action
gigitux 66479da
improve code
gigitux 0bf760d
fix actionId
gigitux 08bb03d
update package-lock.json
gigitux b599c42
remove comment
gigitux 337b3e5
rename function
gigitux 1016ef8
rename functions
gigitux 39d25d1
improve code
gigitux dc03f57
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 599c0a4
Migrate duplicate-template-part action to @wordpress/fields package
gigitux 60e7a58
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 81c0980
fix build
gigitux 7b2bb82
restore files
gigitux d6fcf4a
fix CSS
gigitux 0316536
restore delete post action
gigitux 485237f
fix import order
gigitux 5a4fb59
move to a flat structure
gigitux 0deeed3
remove not necessary file
gigitux d42430d
Merge branch 'add/action-dataviews-2' of github.com:gigitux/gutenberg…
gigitux 400a67d
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 18d6029
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux ff299b6
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 36adb07
regenerate package-lock.json file
gigitux 47da440
generate documentation
gigitux 64423cf
delete constant file
gigitux 199c313
update class
gigitux 8571360
rename styles.scss to style.scss
gigitux 844a98a
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 0bd24a7
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 00533bd
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 13ea482
restore changes
gigitux 6dede40
fix comment
gigitux 63247d0
fix comment
gigitux 3b6b664
improve documentation
gigitux 8857196
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 084383c
Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…
gigitux 4583cf8
export only CreateTemplatePartModal component
gigitux 02da400
Merge branch 'add/action-dataviews-3' of github.com:gigitux/gutenberg…
gigitux e0f518e
restore not necessary changes
gigitux b9fb6f3
export only needed types
gigitux bb1f366
fix fallback value
gigitux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree this is weird, but also not sure what's the best place for these wp-core-data aware components. That said I can live with it being in fields for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a comment explaining the choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 47da440 I added some documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked where this modal is being used. It looks like there are two additional places other than the action:
The second case is a bit more difficult to absorb declaratively because it's very custom. However, it seems the first one ("add new") we should be able to absorb as part of the actions registration. Note how all entities have it. It's a bit complex in patterns due to how they are setup, but I presume we want the same design ("add new" button) for any new registered CPT:
We could look at declare some actions as "insertion", similarly to how some of them are "destructive", perhaps.