Interactivity API: Add typed function to use with generators #65439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…people don’t use it before WP 6.7
This reverts commit ac5590f.
sirreal
added
the
[Type] Task
sirreal
force-pushed
the
iapi-typed-function
branch
from
1d4da07 to
d7422d0
Compare
|
Size Change: +80 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
@sirreal so, what is your proposal for typing asynchronous functions within asynchronous actions? Is there any alternative to the |
|
I haven't prepared an alternative, the concerns I shared in #64577 (comment) still stand. In particular, I don't like that this introduces new functions into the runtime that are only there to satisfy the type system. I'm not sure the tradeoffs of modifying the runtime and introducing another pattern to what's already a confusing part of the API (use generators with yield instead of async/await) is worth it. It's worth reviewing the issues I linked to see if there are other workarounds. |
I haven't been able to find any other workaround. Using a function seemed to be the only way to change the types without doing a manual casting of the return values: // With `typed`
function* getUser(id: number) {
const user = yield* typed(fetchUser(id));
}
// With manual casting
function* getUser(id: number) {
const user = (yield fetchUser(id)) as Typed<typeof fetchUser>;
}Being |
40 tasks
gziolo
changed the title
|
@luisherranz I really should not be the author of this PR. There's no way to transfer, do you want to create a new PR that can be linked and we can close this one? One thought I had to help this move forward is to make sure it's used and tested in Gutenberg to demonstrate how it improves the experience. The interactivity-router store seems like a good candidate since it's using generators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve TypeScript support for generators, including converting types to and from promises, and a
typedfunction to be able to use promise types when yielding.This PR and branch are to land the
typedfunction separately from documentation changes in #64577.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast