-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel preset: Add missing pkg files #65481
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
||
- Fix a bug in 8.8.1 due to missing files in the published package ([#65481](https://github.com/WordPress/gutenberg/pull/65481)). | ||
|
||
## 8.8.0 (2024-09-19) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These headings get generated automatically. We only have to put new changelog entries into the ## Unreleased
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nevermind, I see now you're fixing this entry which should have been automatically placed under ## 8.8.0
but wasn't because there was a missing ## Unreleased
🙂👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I see the previously missing file in the dry run:
npm notice 480B packages/babel-preset-default/polyfill-exclusions.js
Thank you for the PR, @sirreal! 👍
Fix an issue where some files are not included in the published package: @wordpress/[email protected] --- Co-authored-by: sirreal <[email protected]> Co-authored-by: noisysocks <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: sgomes <[email protected]>
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: b53abc2 |
What?
Fix an issue where some files are not included in the npm package: #65292 (comment)
How?
Add the missing files to the package's
package.json
files
field.Testing Instructions
You can do
npm publish --dry-run
from the package to see the included files. Here's a comparison with trunk:The added files from the commit are as follows:
# git diff bf639061fe54dfde3d1f80c9ddbaf02eba52fe31~ bf639061fe54dfde3d1f80c9ddbaf02eba52fe31 --diff-filter=A --name-only packages/babel-preset-default/polyfill-exclusions.js packages/babel-preset-default/replace-polyfills.js packages/babel-preset-default/test/fixtures/polyfill.js packages/dependency-extraction-webpack-plugin/test/fixtures/polyfill-magic-comment/index.js packages/dependency-extraction-webpack-plugin/test/fixtures/polyfill-magic-comment/webpack.config.js