-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icon in home button #65497
Update icon in home button #65497
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +1.71 kB (+0.1%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Flaky tests detected in 1c5d3e4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10945147467
|
I'm not sure a diagonal arrow helps understand the functionality.
|
@afercia agree those are issues to fix, but probably not here. More options: |
The "menu" icon seems as good as it gets for now. Regarding future concerns, if admin bar functionality would stretch the metaphor too much perhaps such functions merit their own UI. |
The diagonal arrow works well, that's a good start, and we can go from there. |
I kindly disagree. This button opens a manu. The icon should represent the concept of a menu. The most common pattern I can think of for such an icon is the so called 'hamburger' icon. As a user, a diagonal arrow doesn't mean much to me. I'm not sure why we'd want to go fancy with obscure, meaningless icons instead of choosing one that clearly represents the concept of a menu. |
Pushed the alternative arrow to try. Based on the current behavior I think the |
Seems to me the prevalent opinion on this change is to use the |
The problem with the menu item is that it can easily be confused with the nav menu block, and even navigation elements for the site itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a visual tension as well between the list view icon and the hamburger in such close proximity. A hamburger menu generally opens in place while the post editor doesn't do that just yet, triggering a full navigation instead, so I think the arrow is a bit more adequate in the current context. We can revisit this during beta if necessary.
*/ | ||
import { SVG, Path } from '@wordpress/primitives'; | ||
|
||
const directionNW = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be named arrowTopLeft
and such for consistency with existing icons.
I totally agree. Though how does one qualify how much it frustrates actual use?
True, yet this seems unlikely to frustrate usage. It is still a good point for broader consideration and it sounds as if we are planning to not have it be a full navigation at some point. The arrow is better than the current box so that’s a win. Yet not using the menu icon still feels like a miss of the practical mark because we’re aiming at perfection (which is currently out of range). |
Co-authored-by: jameskoster <[email protected]> Co-authored-by: mtias <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: paaljoachim <[email protected]> Co-authored-by: annezazu <[email protected]>
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 3be134f |
@stokesman yes, for sure, let's not consider this final |
Yes I'd agree. However, the List View isn't just a list view any longer. The panel contains the List View and the Outline. As such, the toggle button that opens a panel with List View + Outline should be renamed and the icon changed. |
Co-authored-by: jameskoster <[email protected]> Co-authored-by: mtias <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: paaljoachim <[email protected]> Co-authored-by: annezazu <[email protected]>
This reverts commit b0c9b57.
Closes #65428.
What?
Replace the current icon in the home button.
Why?
See #65428.
How?
In this PR I swapped to the
menu
icon. It's not perfect because the explicit metaphor may not fully capture how this element might evolve in the future (absorbing admin bar functionality). However, it is a very familiar icon, and aligns with the current tooltip 'Open navigation'.Other options I ruled out:
<
isn't appropriate because it suggests going back, which isn't always the resulting behavior. We've already iterated away from this once (Update: chevron to home icon. #64161).We can explore new alternative icons here too.
One option could be something like the 'exit full screen' icon in macOS (green button):
Another option could be a diagonal arrow: