Improve the Query Loop block display settings labels. #65524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -6 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
14 tasks
|
Cross connecting this related issue that touches on some of what this PR addresses: #31158 |
Mamaduka
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thank you, @afercia! The changes look good to me ✅
cc @jameskoster
|
Everything here feels like a step in the right direction; though I'll say the "Max pages to show" label can be confusing if the query is configured to display |
|
The "Max pages to show" setting was always confusing for me. Why?
|
|
I agree the "Max pages to show" setting and label is confusing. That has been reported and discussed on other issues as well. I'd agree with @Mamaduka this setting hasn't much to do with the Query Loop in the first place, as it is more a setting of the Pagination block. It's a broader issue that also relates to the relationship between the Query Loop block and hte Pagination block. I'd rather create a new issue if no objections. |
@afercia, we could continue discussing the existing issue you mentioned or consolidate efforts into a single issue. Update: It looks like you've already created those issues - #63027 and #63028. Should we consolidate them into one? |
Yes, or maybe a tracking issue? There is also #31158 from April 2021 😬 that could be used as a tracking issue. |
|
Right, let's use #31158 for tracking. I personally can support dropping that setting altogether. We could check the |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #58207
What?
The labels of the Query Loop display settings can be improved for better usability and consistency.
Why?
Labels should be consistent and meaningful.
Current:
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: