Site Editor: Make resizable frame compatible with RTL languages #65545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +47 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
stokesman
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Nice to see fixes before an issue is even reported. It’ll be like it never happened 😉 but then again I didn’t search for an issue—maybe there is one.
The keyboard resizing works just fine. It happens that I tried dragging and the axis is flipped.
resizable-frame-rtl-drag.mp4
That may as well be addressed here too. Here’s a change I tried that seemed to be the minimal way to get it working as expected:
diff --git a/packages/edit-site/src/components/resizable-frame/index.js b/packages/edit-site/src/components/resizable-frame/index.js
index 0585a3182d..d90aa98601 100644
--- a/packages/edit-site/src/components/resizable-frame/index.js
+++ b/packages/edit-site/src/components/resizable-frame/index.js
@@ -253,10 +253,11 @@ function ResizableFrame( {
size={ frameSize }
enable={ {
top: false,
- right: false,
bottom: false,
// Resizing will be disabled until the editor content is loaded.
- left: isReady,
+ ...( isRTL()
+ ? { right: isReady, left: false }
+ : { left: isReady, right: false } ),
topRight: false,
bottomRight: false,
bottomLeft: false,
@@ -276,7 +277,7 @@ function ResizableFrame( {
onMouseOver={ () => setShouldShowHandle( true ) }
onMouseOut={ () => setShouldShowHandle( false ) }
handleComponent={ {
- left: canvasMode === 'view' && (
+ [ isRTL() ? 'right' : 'left' ]: canvasMode === 'view' && (
<>
<Tooltip text={ __( 'Drag to resize' ) }>
{ /* Disable reason: role="separator" does in fact support aria-valuenow */ }
Co-authored-by: Mitchell Austin <[email protected]>
Good catch! I fixed it using the code you suggested. |
stokesman
approved these changes
Sep 24, 2024
|
Thanks for the review! Regarding the E2E test failure, the cause is being explored here: https://wordpress.slack.com/archives/C02QB2JS7/p1727152145938689 I would like to merge this once this issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR ensures that the resize handles in the site editor are positioned correctly in RTL languages.
How?
I first considered replacing
leftwithinset-inline-start, which is a logical property, butframer-motiondoesn't seem to support this property: motiondivision/motion#1989Therefore, I switched between
leftandrightdepending on the language direction.Testing Instructions
Screenshots or screencast
Before
After