Don't show tooltip in zoom out toggle button when showIconLabels is true #65573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
requested review from
draganescu,
getdave,
MaggieCabrera and
afercia
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +12 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Spoke too soon. There's a few failing tests but they seem unrelated. |
|
Thanks for the review! The cause of the test failure is investigated here: https://wordpress.slack.com/archives/C02QB2JS7/p1727152145938689 |
draganescu
approved these changes
Sep 24, 2024
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 24, 2024
…rue (#65573) Co-authored-by: t-hamano <[email protected]> Co-authored-by: afercia <[email protected]> Co-authored-by: draganescu <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 360c6c8 |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue raised in this comment
What?
Change the toggle button so that a tooltip is not displayed when
showIconLabelsis true.Why?
The button already has text displayed, so the tooltip text is redundant.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After