-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: DropZone when sitelogo is present #65596
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @dhruvang21! It works well in my testing, I'm able to drag a new image in the Site Logo block, and I'm unable to do this on trunk. 🎉
I've left one small suggestion, and I also think this PR needs to be rebased with the latest changes on trunk, as I don't think these test failures are related to this PR.
e03d52c
to
2a08eb1
Compare
Co-authored-by: Sarah Norris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the latest changes, they look good to me 👏
What?
Resolves issue :- 65571
Why?
This PR resolves the issue of Site logo block is missing DropZone when a logo is present.
How?
By adding the dropzone component in to the site logo.
Testing Instructions
Screenshots or screencast
Edit.Site.Logo.webm