Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: DropZone when sitelogo is present #65596

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

dhruvang21
Copy link
Contributor

@dhruvang21 dhruvang21 commented Sep 24, 2024

What?

Resolves issue :- 65571

Why?

This PR resolves the issue of Site logo block is missing DropZone when a logo is present.

How?

By adding the dropzone component in to the site logo.

Testing Instructions

  • open the site editor and select any site logo block or can select any pattern containing site logo
  • add site logo in to the block
  • now again add the logo by dragging the file on to it

Screenshots or screencast

Edit.Site.Logo.webm

Copy link

github-actions bot commented Sep 24, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvang21 <[email protected]>
Co-authored-by: mikachan <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mikachan mikachan added [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block labels Sep 25, 2024
@mikachan mikachan linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @dhruvang21! It works well in my testing, I'm able to drag a new image in the Site Logo block, and I'm unable to do this on trunk. 🎉

I've left one small suggestion, and I also think this PR needs to be rebased with the latest changes on trunk, as I don't think these test failures are related to this PR.

packages/block-library/src/site-logo/edit.js Outdated Show resolved Hide resolved
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the latest changes, they look good to me 👏

@mikachan mikachan merged commit ae1c989 into WordPress:trunk Sep 27, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site logo block is missing DropZone when a logo is present
2 participants