Block Bindings: Fix showing bindings field values in theme templates #65639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
SantosGuillamot
requested review from
gziolo,
artemiomorales and
cbravobernal
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +604 B (+0.03%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
| postContext.postType = match[ 1 ]; | ||
| } | ||
| break; | ||
| const themeSlug = post.slug; |
There was a problem hiding this comment.
I know this case is for theme templates. But still I don't really like the naming.
Maybe we could just use post.slug on the comparisons.
There was a problem hiding this comment.
Changed in this commit 🙂 3344a5b
cbravobernal
approved these changes
Sep 25, 2024
SantosGuillamot
deleted the
fix/show-bindings-fields-in-theme-templates
branch
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 25, 2024
…65639) * Move `is_custom` check to page case * Check themeSlug in conditional * Use `post.slug` directly Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: cbravobernal <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 353c87f |
97 tasks
youknowriad
reviewed
Oct 15, 2024
| // If the slug is single-{postType}, infer the post type from the slug. | ||
| const postTypesSlugs = | ||
| postTypes?.map( ( entity ) => entity.slug ) || []; | ||
| const match = post.slug.match( |
There was a problem hiding this comment.
I noticed that post.slug is not part of the dependencies of the useMemo call which means potentially a hidden bug.
There was a problem hiding this comment.
Thanks for pointing it out. I started this pull request to address that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on adding this test, I realized that connected blocks in CPT templates like
single-movieweren't showing the default values. When you create a single-movie template from the editor, it works as expected. However, when you directly create asingle-movie.htmlin your theme, it doesn't.This pull request aims to solve that.
Why?
It should work for theme files as well.
How?
After triaging it, it seems that
single-movie.htmlis treated as a custom template, even if it is specific to movies. For that reason, I've change the conditional to not rely onpost.is_customand directly check the slug. That conditional was there to cover use cases likepage-custom-template. With the new code, it directly checks that the theme slug matches "page", while previously it was checking the theme slug starts with "page".Testing Instructions
This one is hard to test manually because you need a CPT theme template like
single-movie.htmland cannot be created through the editor UI. It will be covered by this automated test, among others, in the future.Basically, you would need to:
register_meta(
'post',
'movie_title',
array(
'label' => 'Movie Title',
'object_subtype' => 'movie',
'show_in_rest' => true,
'single' => true,
'type' => 'string',
'default' => 'Default movie title',
)
);
single-movie.htmlfile in your theme.