Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove PHPDoc for non-existing parameter #65640

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Soean
Copy link
Member

@Soean Soean commented Sep 25, 2024

What?

The function gutenberg_override_global_styles_endpoint only has a $args parameter, so we should remove the PHPDoc for the non-existing $post_type parameter.

@Soean Soean requested a review from Mamaduka September 25, 2024 09:13
@Soean Soean requested a review from spacedmonkey as a code owner September 25, 2024 09:13
@Soean Soean added the [Type] Developer Documentation Documentation for developers label Sep 25, 2024
Copy link

Flaky tests detected in a95b778.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11030003963
📝 Reported issues:

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Soean!

@Mamaduka Mamaduka added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Sep 25, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Soean <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka merged commit 195c7ef into trunk Sep 25, 2024
68 of 73 checks passed
@Mamaduka Mamaduka deleted the docs/remove-non-existing-arg branch September 25, 2024 12:39
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants