Block Editor: Don't memoize 'getContentLockingParent' and 'getParentSectionBlock' selectors #65649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectionBlock' selectors
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
youknowriad,
jsnajdr,
tyxla and
jorgefilipecosta
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -25 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
So the memoization can be valuable sometimes for selectors that return primitive values, but only if the selector is not great performance wise (compared to checking memoized values). I think for these ones, you're probably right that it's not worth it. |
youknowriad
approved these changes
Sep 25, 2024
|
I think when the selector returns a primitive value, we should follow your advice - measure then optimize. If we notice that the selector performs poorly, then we can look for other solutions like memoization. |
|
Thanks @Mamaduka, another good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #65617.
PR removes memoization for the private
getContentLockingParentand 'getParentSectionBlock' selectors.Why?
The memoization is not particularly valuable here since both selectors return primitive string values.
Testing Instructions
CI checks should be green.