Block Bindings: Fix editing protected custom fields in block bindings #65658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
SantosGuillamot
requested review from
gziolo,
artemiomorales and
cbravobernal
SantosGuillamot
requested review from
ntwb,
nerrad and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -13 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Base automatically changed from
update/pass-registry-to-can-user-edit-value
to
trunk
September 25, 2024 16:46
cbravobernal
force-pushed
the
fix/avoid-editing-protected-custom-fields-in-bindings
branch
from
e972eae to
47f8040
Compare
cbravobernal
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
I merged #65659 and updated this PR with trunk. Let's see the e2e.
cbravobernal
deleted the
fix/avoid-editing-protected-custom-fields-in-bindings
branch
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 25, 2024
…#65658) * Use `getPostMetaFields` in `canUserEditValue` * Add e2e test Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: cbravobernal <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: ab2e860 |
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevent editing protected fields.
This is built on top of #65659
Why?
The same way protected fields can be selected through the UI, I believe that if they are connected through the attributes, they shouldn't be editable.
How?
I'm reusing the
getPostMetaFieldsthat checks the protected fields.Additionally, I'm adding an e2e test to cover this.
Testing Instructions
_protected_field.