Edit Post: Remove unnecessary effect in InitPatternModal
#65734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…5734) Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…dPress#65734)" This reverts commit 6772238.
ntsekouras
reviewed
Oct 7, 2024
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [] ); | ||
| const [ isModalOpen, setIsModalOpen ] = useState( () => | ||
| isNewPost && postType === 'wp_block' ? true : false |
There was a problem hiding this comment.
Super small PR to simplify this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the unnecessary
useEffectfromInitPatternModaland replaces it with conditional lazy state init.Why?
We're allowing the React Compiler to work with this component - previously it was returning this due to our
eslint-ignore:We're also saving an extra rerender.
See #61788.
How?
We're removing the
useEffectcall and moving the conditional logic to lazy state initialization.Testing Instructions
/wp-admin/post-new.php?post_type=wp_block/wp-admin/post-new.phpTesting Instructions for Keyboard
None
Screenshots or screencast