Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BorderBoxControl: Deprecate 36px default size #65752

Merged
merged 5 commits into from
Oct 26, 2024
Merged

BorderBoxControl: Deprecate 36px default size #65752

merged 5 commits into from
Oct 26, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Sep 30, 2024 •
edited
Loading

Part of #65751

What?

Deprecate the 36px default size on BorderBoxControl.

Testing Instructions

  • Unit tests pass
  • Storybook stories should not log console warnings
  • All code snippets in documentation (JSDoc, Storybook, README) should have the __next40pxDefaultSize prop enabled

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Sep 30, 2024
@mirka mirka self-assigned this Sep 30, 2024
@mirka mirka mentioned this pull request Sep 30, 2024
Open
24 tasks
@mirka mirka added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Sep 30, 2024
@mirka mirka added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Sep 30, 2024
@mirka mirka mentioned this pull request Sep 30, 2024
Merged
@mirka mirka marked this pull request as ready for review September 30, 2024 16:35
@mirka mirka requested a review from ajitbohra as a code owner September 30, 2024 16:35
@mirka mirka requested a review from a team September 30, 2024 16:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: DaniGuardiola <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ciampo
ciampo reviewed Sep 30, 2024
View reviewed changes
packages/components/src/border-box-control/border-box-control/hook.ts
@@ -39,6 +40,12 @@ export function useBorderBoxControl(
...otherProps
} = useContextSystem( props, 'BorderBoxControl' );

maybeWarnDeprecated36pxSize( {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this new utility for any existing component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything except for FormFileUpload and Button, which will need more specific conditional logic.

ciampo
ciampo approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Should we consider refactoring the only usage of BorderBoxControl from size="__unstable-large" to __next40pxDefaultSize?

DaniGuardiola
DaniGuardiola approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@DaniGuardiola DaniGuardiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mirka mirka removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 1, 2024
@mirka
Copy link
Member Author

mirka commented Oct 1, 2024

Should we consider refactoring the only usage of BorderBoxControl from size="__unstable-large" to __next40pxDefaultSize?

Yes, maybe as a repo-wide cleanup!

@mirka mirka merged commit 76a5ba1 into trunk Oct 26, 2024
63 checks passed
@mirka mirka deleted the 40px-deprecation-1 branch October 26, 2024 12:11
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 26, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
@mirka @ciampo @karthick-murugan
BorderBoxControl: Deprecate 36px default size (WordPress#65752)
3d11082 
* Add utility function

* BorderBoxControl: Deprecate 36px default size

* Fix naming

* Add changelog

Co-authored-by: mirka <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: DaniGuardiola <[email protected]>
@mirka mirka mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniGuardiola DaniGuardiola DaniGuardiola approved these changes

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@mirka mirka

Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 19.6
Development

Successfully merging this pull request may close these issues.
3 participants
@mirka @ciampo @DaniGuardiola