Customize widgets, edit post: refactor Button to new sizes #65807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
changed the title
ciampo
added
[Type] Code Quality
ciampo
commented
Oct 1, 2024
| variant="secondary" | ||
| ref={ ref } | ||
| > | ||
| <Button size="compact" variant="secondary" ref={ ref }> |
There was a problem hiding this comment.
- Active an non-blocks based theme
- Artificially
throwsomewhere in the package ( - Visit customizer, then widgets
Note: this button inherits some very generic style overrides, although this code is so legacy that we can probably keep it as-is without worrying too much.
There was a problem hiding this comment.
I'm okay with the style overrides FWIW, but I think this is a perfect fit for the size="compact", given the size of the neighbor buttons that are likely to not change in the future.
There was a problem hiding this comment.
Makes sense — so, just to make sure, no changes needed for this instance since size="compact" is already being applied?
The height doesn't look like the compact size because of the mentioned style overrides, which change (among other things) the box-sizing CSS property, causing the height of the button to be different than intended.
There was a problem hiding this comment.
That's correct 👍
And whether we want to play with the style overrides in this PR in order to make the button height match better, I'll leave this to your judgment.
There was a problem hiding this comment.
I'd leave it since it's a legacy part of the codebase, and this error screen should (hopefully) not be seen often by users 🤞
ciampo
commented
Oct 1, 2024
| @@ -37,8 +37,7 @@ function Inserter( { setIsOpened } ) { | |||
| { __( 'Add a block' ) } | |||
| </h2> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| size="small" | |||
There was a problem hiding this comment.
- Active an non-blocks based theme
- Visit customizer, then widgets, then click on the "+" icon button
I picked size="small" to be coherent with the other "X" button (which is defined somewhere else in the codebase)
ciampo
commented
Oct 1, 2024
| @@ -43,8 +43,7 @@ export default function WelcomeGuide( { sidebar } ) { | |||
| ) } | |||
| </p> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
- Active an non-blocks based theme
- Visit customizer, then widgets. The guide will display on first visit
There was a problem hiding this comment.
Similarly, to be consistent with the sizing of the other buttons, I'd personally prefer size="compact" for this one.
ciampo
commented
Oct 1, 2024
| @@ -91,8 +91,7 @@ function FullscreenModeClose( { showTooltip, icon, href, initialPost } ) { | |||
| return ( | |||
| <motion.div whileHover="expand"> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
ciampo
commented
Oct 1, 2024
| @@ -82,8 +82,7 @@ export default function InitPatternModal() { | |||
| /> | |||
| <HStack justify="right"> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Visit /wp-admin/post-new.php?post_type=wp_block
ciampo
commented
Oct 1, 2024
| @@ -39,8 +39,7 @@ export function CustomFieldsConfirmation( { willEnable } ) { | |||
| ) } | |||
| </p> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
- Edit a post
- Open the preferences modal
- Toggle the "Custom fields" option in the "Advanced" section
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
21 tasks
|
Size Change: -33 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Looking good and testing well 👍
One thing: I'd personally prefer if we used compact buttons in the customizer, since that's closer to the size of the core buttons there. WDYT? See my inline comments.
I've also made some minor optional cleanup suggestions, feel free to take or toss.
| variant="secondary" | ||
| ref={ ref } | ||
| > | ||
| <Button size="compact" variant="secondary" ref={ ref }> |
There was a problem hiding this comment.
I'm okay with the style overrides FWIW, but I think this is a perfect fit for the size="compact", given the size of the neighbor buttons that are likely to not change in the future.
| @@ -37,8 +37,7 @@ function Inserter( { setIsOpened } ) { | |||
| { __( 'Add a block' ) } | |||
| </h2> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| size="small" | |||
| className="customize-widgets-layout__inserter-panel-header-close-button" | |||
There was a problem hiding this comment.
I think we can remove this classname as it's unnecessary and I don't see usage in wpdirectory.
| @@ -43,8 +43,7 @@ export default function WelcomeGuide( { sidebar } ) { | |||
| ) } | |||
| </p> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Similarly, to be consistent with the sizing of the other buttons, I'd personally prefer size="compact" for this one.
| @@ -43,8 +43,7 @@ export default function WelcomeGuide( { sidebar } ) { | |||
| ) } | |||
| </p> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| className="customize-widgets-welcome-guide__button" | |||
There was a problem hiding this comment.
And another potentially removable classname.
| @@ -39,8 +39,7 @@ export function CustomFieldsConfirmation( { willEnable } ) { | |||
| ) } | |||
| </p> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| className="edit-post-preferences-modal__custom-fields-confirmation-button" | |||
There was a problem hiding this comment.
Another classname to remove while we're here. The last usage of this one was removed a while ago in #35369.
You might need to update some snapshots if you remove it.
ciampo
force-pushed
the
fix/button-40px-customize-widgets-edit-post
branch
from
492a0d2 to
ff87070
Compare
tyxla
approved these changes
Oct 2, 2024
|
Flaky tests detected in ff87070. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11144965151
|
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…#65807) * Customize widgets, edit post: refactor Button usages to new component sizing * Update snapshots * Switch to compact size in the customize widgets welcome guide * Remove unused classnames, update snapshots --- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…ordPress#65807)" This reverts commit cd0916c.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Customize widgets, edit post: refactor Button usages to new component sizing * Update snapshots * Switch to compact size in the customize widgets welcome guide * Remove unused classnames, update snapshots --- Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #65018
Migrate some of the existing usages of
Buttonto the new 40px sizingWhy?
See #65018
How?
By either setting
__next40pxDefaultSizetotrue, or by applying a differentsizeTesting Instructions
See individual comments