-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite: always await initial render setup in unit tests #65823
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 74ad0b4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11142730036
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, let's do it 👍 🚀
Makes you wonder why we weren't awaiting in the first place 🤔
…#65823) Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
…ordPress#65823)" This reverts commit aa6a066.
Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
What?
Extracted from #65720
Always
await
for the initial render setup inComposite
unit testsWhy?
Looking at the code, it looks like the correct thing to do is to
await
for that setup function to execute.This change should improve test reliability (I think I've seen some flakiness around composite tests).
How?
By
await
ing every call to therenderAndValidate
utility in unit testsTesting Instructions
Unit tests should continue passing (and if there was any flakiness, that should improve)