Filter UI: Remove popover max height #65835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
Flaky tests detected in daa5b14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11146954661
|
youknowriad
approved these changes
Oct 2, 2024
|
Not sure the max-height is the solution to the following, but ideally the component has smarts so that it would never cause a vertical scrollbar in something like the site editor, so you could scroll the frame out of view. Similar smarts (which I think are already present) is opening upwards when there's not room to open downwards, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove
max-heighton the filter popover UI.Why?
The value is a little aggressive, leading to status being clipped in the pages data view:
How?
By removing the
max-heightstyle the height of the popover will be governed by the underlying component, which already handles potential visibility issues caused by the viewport size:list.mp4
Testing Instructions