Button: Move to stricter lint rule for 40px size adherence #65840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -111 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
mirka
commented
Oct 2, 2024
| @@ -177,8 +177,7 @@ function PostTemplateDropdownContent( { onClose } ) { | |||
| { canEdit && onNavigateToEntityRecord && ( | |||
| <p> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Activate a classic theme (e.g. Twenty Twelve) and open a page in the block editor.
No visible change because this is a link variant.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
21 tasks
ciampo
approved these changes
Oct 2, 2024
Tweaked the wording so it applies more broadly: 7ea1a25 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…#65840) * Fix last remaining instance * Button: Move to stricter lint rule * Tweak wording to account for `size` variants Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65018
Closes #63871
What?
Moves
Buttonto the stricter lint rule for adherence to the 40px default size.Also fixes the last remaining violation.
Testing Instructions
✅
npm run lint:js -- --quietpasses