Type the router package #65854
Merged
Type the router package #65854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -2 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f8870f3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11161502129
|
sirreal
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Good stuff, thank you.
I left some suggestions, but nothing major in the changes. 2 additional changes I think would be good:
- A changelog note
- I think
"types": "build-types"should be added to the package.json to expose this package's types like other packages do.
sirreal
reviewed
Oct 3, 2024
Co-authored-by: Jon Surrell <[email protected]>
youknowriad
force-pushed
the
update/type-router
branch
from
550450f to
fe0eed8
Compare
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: sirreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make some changes to the router package but I noticed that it was not typed yet (which I needed for my changes). so this is just a small PR that updates that package to typescript.