Block Bindings: Register bindings sources in widgets screens #65937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Enhancement
SantosGuillamot
requested review from
draganescu,
adamziel and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The only remaining place I saw where |
|
Size Change: +116 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Oct 8, 2024
SantosGuillamot
force-pushed
the
fix/register-bindings-sources-in-widgets-screens
branch
from
e06e3ca to
ced8b9e
Compare
SantosGuillamot
deleted the
fix/register-bindings-sources-in-widgets-screens
branch
64 tasks
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ss#65937) * Register sources in customize-widgets * Register sources in edit-widgets Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: gziolo <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As reported here, I'm registering the core sources and bootstrapping the server ones in the widgets screens.
Why?
They should be available in that place as well.
How?
Just using the core functions to do so.
Testing Instructions
This one is a bit tricky to test because post meta fields are not available in the widgets context, custom sources bindings can't be created through the UI yet, and the widgets screens don't support the "Code Editor" I believe.
Test Widgets screen
5. Go to Appearance -> Widgets, and paste the copied block into any widget.
6. Check that the "Custom Source" label is shown. Previously, it showed the "Fallback" value.
Test Customize Widgets screen
5. Go to Appearance -> Customize -> Widgets, and paste the copied block into any widget.
6. Check that the "Custom Source" label is shown. Previously, it showed the "Fallback" value.