Add FontSizePicker component and refactor paragraph block to use it. #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
gziolo
approved these changes
May 9, 2018
| @@ -366,7 +351,7 @@ export const settings = { | |||
|
|
|||
| const textClass = getColorClass( 'color', textColor ); | |||
| const backgroundClass = getColorClass( 'background-color', backgroundColor ); | |||
| const fontSizeClass = fontSize && FONT_SIZES[ fontSize ] && `is-${ fontSize }-text`; | |||
| const fontSizeClass = fontSize && `is-${ fontSize }-text`; | |||
There was a problem hiding this comment.
Yes, it is safe to remove this check. And I think, we should remove it. If we have set of font sizes now, and later we change the set we should probably keep using the same classes as before we should not remove the class just because we changed the set of FONT_SIZES. This will be changed again in #6628 when this logic is abstracted and removed from the paragraph.
This change makes font size UI generic and allows other blocks to take advantage of the same UI used in the paragraph. Other changes will follow that will abstract other font size logic from paragraph (not just the UI). Themes will also be able to configure the font sizes. The future changes will use this work.
jorgefilipecosta
force-pushed
the
add/font-size-picker
branch
from
cfda02b to
57a5512
Compare
|
Thank you for the review @gziolo, the readme was added before the merge 👍 |
|
This is exactly the kind of thing I'm referencing in #6651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes font size UI generic and allows other blocks to take advantage of the same UI used in the paragraph.
Other changes will follow that will abstract other font size logic from paragraph (not just the UI).
Themes will also be able to configure the font sizes.
This PR is the first in a series of PR's that implement the required changes.
Addresses part of #5714.
This PR is just a refactor no noticeable changes are expected.
How has this been tested?
Verify the font size changer in the paragraph continues to work exactly as before.