Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tests tooling : Compare performance with correct branch #66196

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

cbravobernal
Copy link
Contributor

What?

Target Performance tests to base branch instead of just Trunk.

Why?

If trunk differs from another base branch, like wp/6.7, changing for example selectors. Performance tests will fail on all cherry picks to releases branches.

Testing Instructions

I'll make this PR to 6.7 to see if performance is being executed there.

@cbravobernal cbravobernal added [Type] Bug An existing feature does not function as intended [Type] Performance Related to performance efforts labels Oct 17, 2024
@cbravobernal cbravobernal requested a review from desrosj as a code owner October 17, 2024 09:56
Copy link

github-actions bot commented Oct 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: cbravobernal <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: SantosGuillamot <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@cbravobernal cbravobernal added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Oct 17, 2024
@youknowriad youknowriad removed [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Oct 17, 2024
@youknowriad youknowriad added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 17, 2024
@cbravobernal cbravobernal enabled auto-merge (squash) October 17, 2024 10:23
@SantosGuillamot
Copy link
Contributor

Thanks for the fix 🙂 I wasn't sure why the performance tests were failing in manual cherry picks like this one: link.

@cbravobernal cbravobernal merged commit ab46764 into trunk Oct 17, 2024
63 checks passed
@cbravobernal cbravobernal deleted the fix/compare-performance-with-correct-branch branch October 17, 2024 10:51
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 17, 2024
@github-actions github-actions bot removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Oct 17, 2024
Copy link

I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: f98cdf7

gutenbergplugin pushed a commit that referenced this pull request Oct 17, 2024
…6196)

* Target base branch instead of just trunk

* Update description

Co-authored-by: cbravobernal <[email protected]>
Co-authored-by: youknowriad <[email protected]>
@github-actions github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Oct 17, 2024
@cbravobernal cbravobernal added the [Type] Bug An existing feature does not function as intended label Oct 30, 2024
@SantosGuillamot SantosGuillamot removed the [Type] Performance Related to performance efforts label Oct 30, 2024
@cbravobernal cbravobernal changed the title Performance tests : - Fix/compare performance with correct branch Performance tests tooling : Compare performance with correct branch Oct 30, 2024
@cbravobernal cbravobernal added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 30, 2024
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: [Type] Bug, [Type] Build Tooling, Backported to WP Core.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
…rdPress#66196)

* Target base branch instead of just trunk

* Update description

Co-authored-by: cbravobernal <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants