Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Interactivity API - missing styles in the sample code #66253

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

atachibana
Copy link
Contributor

What?

In the sample code in the ‘Declarative vs. imperative’ section:

The activate/deactivate button: Toggles the paragraph's text and color between "active" (green) and "inactive" (red).

the paragraph text has no color due to the lack of styles.

Also, in the bug description:

Therefore, the next time the user presses Show, the paragraph will not appear in red.

the lack of color in the text makes it difficult to see the difference on screen.

@juanmaguitar

Why?

How?

Add the style in the code.
This should be written in a separate file, but for simplicity, it is written directly in the html / php file.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Copy link

github-actions bot commented Oct 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: atachibana <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Developer Documentation Documentation for developers [Feature] Interactivity API API to add frontend interactivity to blocks. labels Jan 14, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @atachibana!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 14, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 14, 2025
@Mamaduka Mamaduka merged commit 669662c into WordPress:trunk Jan 14, 2025
70 of 75 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants