DropdownMenuV2: rename to Menu
#66289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -25 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
ciampo
added
[Type] Enhancement
ciampo
requested review from
ajitbohra,
ndiego and
tellthemachines
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 85c9ce1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11444463017
|
tyxla
reviewed
Oct 22, 2024
There was a problem hiding this comment.
While I generally agree with Menu being a good pick with all the semantical and accessibility considerations, and the popover/dropdown wrapper being just a design detail, I'm wondering if you've considered the existing menu-like components (MenuGroup and MenuItem for example), which may start to feel confusing if we have a Menu component group with subcomponents? Specifically, won't it be confusing to folks who want to create a non-dropdown menu (what MenuGroup and MenuItem do)?
I'd love to hear some feedback from @mirka and @DaniGuardiola on this one.
My plan would be to deprecate those components, and replace them with the new
To render a menu without the dropdown part (which I don't think can be done with the current set of components), we would export a |
Seconding this. In the component audit with @mattrwalker and @auareyou, I also wrote down that the |
|
Perfect. I'm good with that plan, let's proceed! 👍 |
ciampo
force-pushed
the
refactor/dropdown-menu-to-menu
branch
from
85c9ce1 to
4b5cb52
Compare
ciampo
force-pushed
the
refactor/dropdown-menu-to-menu
branch
from
4b5cb52 to
48177d8
Compare
|
Rebased to include changes from #66473. This PR is now ready for a round of review. |
ciampo
commented
Oct 28, 2024
tyxla
reviewed
Oct 28, 2024
packages/dataviews/src/components/dataviews-item-actions/index.tsx
Outdated
Show resolved
Hide resolved
|
@tyxla I should have addressed all feedback |
tyxla
approved these changes
Oct 29, 2024
9 tasks
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Rename the experimental (private)
DropdownMenuV2component toMenuWhy?
The "dropdown" part of the name implied that the component can only be displayed as a menu inside of a popover, activated by a trigger.
For the sake of reusability, we don't want to preclude the possibility that the component can offer a "menu" primitive (eg. "menu list") that doesn't necessarily render inside a popover.
The "Menu" name also better aligns with the WAI-ARIA "menu" pattern and with how ariakit named its equivalent component.
How?
Find and replace.
Testing Instructions
Smoke test Storybook and the editor, make sure that all usages of the component work as expected.