Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HEIC files selectable from “Upload” button #66292

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Ensure HEIC files selectable from “Upload” button #66292

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffb1216
Ensure HEIC files selectable from “Upload” button
adamsilverstein Oct 21, 2024
5b706e7
Update packages/components/src/form-file-upload/index.tsx
adamsilverstein Oct 22, 2024
33b5e17
Merge branch 'trunk' into fix/heic-upload
adamsilverstein Oct 23, 2024
1a139f6
move “image/heic” addition to FormFileUpload component
adamsilverstein Oct 23, 2024
cd0e248
add image/heif
adamsilverstein Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/background-image-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ function BackgroundImageControls( {
mediaId={ id }
mediaURL={ url }
allowedTypes={ [ IMAGE_BACKGROUND_TYPE ] }
accept="image/*"
accept="image/*, image/heic"
onSelect={ onSelectMedia }
popoverProps={ {
className: clsx( {
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/image/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ export function ImageEdit( {
onSelectURL={ onSelectURL }
onError={ onUploadError }
placeholder={ placeholder }
accept="image/*"
accept="image/*, image/heic"
allowedTypes={ ALLOWED_MEDIA_TYPES }
handleUpload={ ( files ) => files.length === 1 }
value={ { id, src } }
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/image/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ export default function Image( {
mediaId={ id }
mediaURL={ url }
allowedTypes={ ALLOWED_MEDIA_TYPES }
accept="image/*"
accept="image/*, image/heic"
onSelect={ onSelectImage }
onSelectURL={ onSelectURL }
onError={ onUploadError }
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/post-featured-image/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export default function PostFeaturedImageEdit( {
image = (
<MediaPlaceholder
onSelect={ onSelectImage }
accept="image/*"
accept="image/*, image/heic"
allowedTypes={ ALLOWED_MEDIA_TYPES }
onError={ onUploadError }
placeholder={ placeholder }
Expand Down Expand Up @@ -363,7 +363,7 @@ export default function PostFeaturedImageEdit( {
mediaId={ featuredImage }
mediaURL={ mediaUrl }
allowedTypes={ ALLOWED_MEDIA_TYPES }
accept="image/*"
accept="image/*, image/heic"
onSelect={ onSelectImage }
onError={ onUploadError }
onReset={ () => setFeaturedImage( 0 ) }
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/form-file-upload/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { FormFileUpload } from '@wordpress/components';

const MyFormFileUpload = () => (
<FormFileUpload
accept="image/*"
accept="image/*, image/heic"
onChange={ ( event ) => console.log( event.currentTarget.files ) }
>
Upload
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/form-file-upload/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import type { FormFileUploadProps } from './types';
*
* const MyFormFileUpload = () => (
* <FormFileUpload
* accept="image/*"
* accept="image/*, image/heic"
adamsilverstein marked this conversation as resolved.
Show resolved Hide resolved
* onChange={ ( event ) => console.log( event.currentTarget.files ) }
* >
* Upload
Expand Down
Loading