Update a few function definitions

[tyxla]

What?

Changing a few arrow functions to be regular functions.

Why?

To unblock #65463.

For some reason @typescript-eslint/typescript-estree breaks parsing those constructs when an arrow function is used, while using a regular function works well.

When fixing those, we're able to run react-scanner properly without it failing on those functions

How?

We're just changing a few arrow functions to be proper functions, the rest is the same

Testing Instructions

• All checks should be green. This is a minor syntax change.
• If you want to test with React Scanner:
  • Checkout Introduce React Scanner for component usage stats #65463
  • Run npm install
  • Run npm run component-usage-stats > stats.json
  • You'll see 3 errors (see "screenshots or screencast" below)
  • Run git cherry-pick 1257ccef14c3e0165a71a1195237ec37724f0273 to get the commit from this branch.
  • Run npm run component-usage-stats > stats.json
  • You'll see no errors.

Testing Instructions for Keyboard

Same

Screenshots or screencast

Errors we see with #65463:

Failed to parse: gutenberg/packages/components/src/spacer/hook.ts
Failed to parse: gutenberg/packages/data-controls/src/index.ts
Failed to parse: gutenberg/packages/fields/src/mutation/index.ts

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <[email protected]>
Co-authored-by: ciampo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[ciampo]

LGTM 🚀

It's werid that those function definitions caused problems in the first place. Maybe we should open an issue with the @typescript-eslint/typescript-estree project

[tyxla]

BTW the error comes from #66213 and I'm resolving it in #66316

[tyxla]

Maybe we should open an issue with the @typescript-eslint/typescript-estree project

Will do 👍

[tyxla]

Maybe we should open an issue with the @typescript-eslint/typescript-estree project

Will do 👍

Looks like it's been a known issue for a while: typescript-eslint/typescript-eslint#1236

[github-actions]

Flaky tests detected in 1257cce.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11458582363
📝 Reported issues:

• [Flaky Test] inserts a block in proper place after having clicked Browse All from inline inserter #35280 in /test/e2e/specs/editor/various/inserting-blocks.spec.js