Inline Commenting: Show the reply field when a thread is focussed #66417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -7 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
I don't think we should immediately select/focus the comment when you click on a block. Maybe we should highlight it, yes, but not select/focus it. Only once you select/focus the comment/thread, show the reply field at the bottom. Maybe we need some design input for the highlighting, cc @jasmussen |
|
Flaky tests detected in ffd26bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11913123540
|
|
Good question, I welcome accessibility best practice advice here. What would be a good experience for someone using a screen reader? I could see solid arguments both ways: Keeping focus in the canvas: you focused a button to add a comment, but focus was not transferred there so it's not disorienting as to where you are actually editing. Downside: clicking the button actually creates a comment, so assuming your intent by clicking the comment was to write one, you then have to press Esc, Esc, Tab, Tab, Tab, in order to type out the comment you just added. Transferring focus to the comment: you invoked the action to "Comment", and now focus is either on the comment itself, the first tabbable item, or the first input field. Benefit: presumably this actually represents your intent: I want to type a comment, and the focus transfer actually takes you to the proper context. Downside, you lose your place in the canvas. What Google does seems reasonable, treating it fully as a modal interaction:
Is this flow reasonable for the block editor as well? |
|
Closing this out as this enhancement is covered on #67385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of - #66377
What? & Why?
In inline commenting functionality, Reply input box display on click of reply link of thread. Requirement is to display the reply input on select of thread.
How?
This PR remove the reply button from the dropdown menu on thread and make the reply input visible when thread is focussed or selected.
Testing Instructions
Gutenberg->ExperimentsScreenshots or screencast
Edit-Post-.Hello-world-.-.-gutenberg-.-WordPress.webm