Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer: Add border support #66443

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link
Contributor

@karthick-murugan karthick-murugan commented Oct 25, 2024

What?

Add border block support to the Spacer block.

Part of #43247

Why?

Spacer block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  • Go to Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  • Make sure that Spacer block's border is configurable via Global Styles
  • Verify that Global Styles are applied correctly in the editor and frontend
  • Edit template/page, Add Spacer block and Apply the border styles
  • Verify that block styles take precedence over global styles
  • Verify that block borders display correctly in both the editor and frontend

Testing Instructions for Keyboard

None

Screenshots or screencast

In Backend:
spacer_backend

In Frontend:
spacer_frontend

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 25, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthick-murugan! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Block] Spacer Affects the Spacer Block label Oct 25, 2024
@akasunil akasunil added the [Type] Enhancement A suggestion for improvement. label Oct 29, 2024
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this PR @karthick-murugan 👍

I'm not sure adding visual styles to the Spacer block is the direction we want to go. My understanding is this block is meant purely for layout and spacing purposes.

The same concern is raised over on the PR proposing to add color support to the Spacer block (#66433).

I've added the Needs Design Feedback label in order to get a design perspective on this.

@aaronrobertshaw aaronrobertshaw added the Needs Design Feedback Needs general design feedback. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Spacer Affects the Spacer Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants