Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BlockMover Stories and README #66519
Update BlockMover Stories and README #66519
Changes from 3 commits
e7707db
af4c05a
ddbc826
ee7f4f1
027e587
99b0190
ee98912
a865f22
693b8ee
a5dd59d
bcd9a92
66a811d
b53d948
973b820
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to use CSF 3 format, since we're overhauling anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed the types, is it OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do recommend it in this case, as we can eliminate a lot of unnecessary code.
The main points of this suggested diff being:
Template
component is unnecessary because it's just the plain component, and we only use it once. Plus, the implementation is incorrect because theclientIds
prop cannot be overridden by the stories.useEffect
in the Horizontal story can also be moved to a decorator.blocks.length
seem unnecessary because we are assigning theblocks
variable statically.