Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Global styles navigation button accessible name #66535

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix: Global styles navigation button accessible name #66535

wants to merge 1 commit into from
+5 −1

Conversation

up1512001
Copy link
Member

What?

Fix Global styles footer button accessible name.

Why?

fixes #66526

How?

  • updated aria-label from Revisions to Last modified %s same as available text.

Testing Instructions

  • create style revision.
  • open styles -> check Last modified accessible name.

Screenshots or screencast

Screen.Recording.2024-10-28.at.23.30.38.mov

@up1512001 up1512001 added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Package] Edit Site /packages/edit-site labels Oct 28, 2024
@up1512001 up1512001 requested a review from afercia October 28, 2024 18:02
@up1512001 up1512001 self-assigned this Oct 28, 2024
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

afercia
afercia requested changes Oct 29, 2024
View reviewed changes
packages/edit-site/src/components/sidebar-navigation-screen-details-footer/index.js
aria-label={ __( 'Revisions' ) }
aria-label={ sprintf(
/* translators: %s: human readable time difference */
__( 'Last modified %s' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whiel this solves the mismatch, I'm not sure it would be an appropriate label. This button is a navigational tool. Its label should communicate what the button does. Additional information should be moved out of the button. As such, this would need some design changes and I'd recommend to wait for some more design and accessibility feedback.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

This was referenced Oct 30, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afercia afercia afercia requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@up1512001 up1512001

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global styles navigation button: avoid visible text and accessible name mismatch
2 participants
@up1512001 @afercia