Revert: Fix unable to remove empty blocks on merge (#65262) + alternative #66564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Writing Flow
|
Size Change: -111 B (-0.01%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
approved these changes
Nov 11, 2024
|
Thank you Nik! |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…+ alternative (WordPress#66564) Co-authored-by: ellatrix <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: kspilarski <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: kevin940726 <[email protected]> Co-authored-by: richtabor <[email protected]>
jsnajdr
reviewed
Dec 10, 2024
| @@ -47,8 +47,6 @@ import { PrivateBlockContext } from './private-block-context'; | |||
|
|
|||
| import { unlock } from '../../lock-unlock'; | |||
|
|
|||
| const { isUnmodifiedBlockContent } = unlock( blocksPrivateApis ); | |||
There was a problem hiding this comment.
Nice to see that we have one less private API now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #45075, I added a writing flow behaviour that would unwrap the first paragraph or heading inside a list, quote or group block. #65174 suggests that this behaviour is a bit too much for group blocks. It seems the boundary around group blocks needs to be a little stronger (it's always hard to strike a good balance). The solution would be to exclude the group block from this behaviour. This can easily be done by restricting the behaviour to blocks within the
textcategory block (includes quote and list, but excludes group). I have made this change in 9d5dde4.#65262 took an alternative, much more complex, approach. It basically checks if the content of the block to be moved/merged/deleted is empty, but applies this behaviour also to quote blocks. Another issue is that non-empty blocks will still be moved. The added complexity is also significant, so I opted to revert it in c432469.
Closes #65174.
Why?
See #65174 and the explanation above.
How?
See above, let's exclude non textual blocks from this behaviour.
Testing Instructions
Now to the following for list and quote
Additionally, this provides a generalised solution for removing an aligned paragraph. Test the following content:
In trunk, backspace from this paragraph will not do anything. With this PR, it will remove the alignment.
Testing Instructions for Keyboard
Screenshots or screencast