Inline Commenting: Update placement of reply input and add author info header #66580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
…e-commenting-reply-input-placement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -29 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Thanks! It would be nice if you could simply click on a comment to show the reply field, instead of having to click the three dots. Can be done separately of course. |
ellatrix
approved these changes
Oct 30, 2024
ellatrix
reviewed
Oct 30, 2024
| * | ||
| * @return {JSX.Element} The JSX element representing the author's information. | ||
| */ | ||
| function CommentAuthorInfo( { avatar, name, date } ) { |
There was a problem hiding this comment.
Can't we reuse this in AddComment?
There was a problem hiding this comment.
yes, definitely. I'll update the PR.
yes. I'm working on this in another PR. |
|
@akasunil Why does the main comment form not have the text area, while the reply form does? This can probably also be reused and should be the same? The only difference between both forms should be that one has a button that says "Comment", and the other a button that says "Reply", otherwise both of these are the same? |
|
Flaky tests detected in 51ef3b1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11665358904
|
I have extracted comment form to separate component for re-usability and consistency. Now, all ( new comment, edit comment and reply ) form will have the text area for comment input. |
|
@ellatrix Could use your review here. |
|
It was already approved :) |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of - #66377
What? & Why?
How?
CommentFormcomponent for re-usability and consistency.Testing Instructions
Gutenberg->ExperimentsScreenshots or screencast