Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Commenting: Disable comments on published posts for now. #66583

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

rinkalpagdar
Copy link
Contributor

What?

Part of - #66377

How?

This PR disabled the block comments feature for published posts for now.

Testing Instructions

  1. Enable experimental inline commenting option under Gutenberg -> Experiments
  2. Edit any post/page which is published
  3. Make sure the comments feature is not accessible for the published posts.

Copy link

github-actions bot commented Oct 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Oct 30, 2024
Comment on lines 65 to 68
const postStatus = useSelect((select) => {
const post = select(editorStore).getCurrentPost();
return { postStatus: post?.status };
}, []);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail ESLint checks. I would recommend using ELSlint and Prettier code editor extensions.

See: https://developer.wordpress.org/block-editor/contributors/code/getting-started-with-code-contribution/#developer-tools

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rinkalpagdar!

@Mamaduka Mamaduka merged commit f0ef1ac into WordPress:trunk Oct 30, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 30, 2024
@cbravobernal cbravobernal added the [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration label Oct 30, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows [Feature] Real-time Collaboration Phase 3 of the Gutenberg roadmap around real-time collaboration [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants