-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve accessibility and consistency of the 'Last modified' Revisions button. #66606
Changes from all commits
bfbf121
f1fb99e
760a2c8
a387ea2
661a263
318ea6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -18,7 +18,7 @@ | |||||
.edit-site-sidebar-navigation-screen__content { | ||||||
padding: 0 $grid-unit-20; | ||||||
|
||||||
.components-item-group { | ||||||
.edit-site-sidebar-navigation-screen-details-footer { | ||||||
margin-left: -$grid-unit-20; | ||||||
margin-right: -$grid-unit-20; | ||||||
} | ||||||
|
@@ -127,9 +127,14 @@ | |||||
bottom: 0; | ||||||
background-color: $gray-900; | ||||||
gap: 0; | ||||||
padding: $grid-unit-20 0; | ||||||
padding: $grid-unit-10 $grid-unit-20; | ||||||
margin: $grid-unit-20 0 0; | ||||||
border-top: 1px solid $gray-800; | ||||||
|
||||||
.components-item-group { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Let's avoid using |
||||||
margin-left: -$grid-unit-20; | ||||||
margin-right: -$grid-unit-20; | ||||||
} | ||||||
} | ||||||
|
||||||
/* In general style overrides are discouraged. | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the
SidebarNavigationScreenDetailsPanelValue
component isn't being used anywhere anymore, we should be able to delete the component itself.packages/edit-site/src/components/sidebar-navigation-screen-details-panel/sidebar-navigation-screen-details-panel-value.js