Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook: Improve component organisation - Actions #66680

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Storybook: Improve component organisation - Actions #66680

merged 2 commits into from
Nov 12, 2024

Conversation

Vrishabhsk
Copy link
Contributor

What?

  • Move Menu component under Actions folder

Why?

@Vrishabhsk Vrishabhsk requested a review from ajitbohra as a code owner November 1, 2024 15:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Vrishabhsk <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Vrishabhsk Vrishabhsk mentioned this pull request Nov 1, 2024
Closed
9 tasks
@tyxla tyxla added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components Storybook Storybook and its stories for components labels Nov 7, 2024
@Vrishabhsk Vrishabhsk requested a review from tyxla November 7, 2024 14:26
mirka
mirka approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mirka mirka merged commit 9be61c4 into WordPress:trunk Nov 12, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.7 milestone Nov 12, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
@Vrishabhsk @tyxla
@mirka @karthick-murugan
Storybook: Improve component organisation - Actions (WordPress#66680)
a318a45 
* Move Menu component under Actions container

* Add id

Co-authored-by: Vrishabhsk <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: mirka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@tyxla tyxla Awaiting requested review from tyxla

Assignees

@Vrishabhsk Vrishabhsk

Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 19.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Vrishabhsk @mirka @tyxla