Fix navigate to entity crash in Post Editor for 6.7 #66709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Size Change: -22 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
changed the title
getdave
added
the
[Priority] Low
|
I'm going to suggest we aim to fix this for 6.7.1. No one feels confident on the impact of the change and we're very close the final release. That said I'd still appreciate reviews and/or someone to take this PR over the line. |
|
Based on this the main impact of this change is that the function becomes async. This means it will always return a Promise. The callback tends to happen in an event handler (e.g. |
getdave
commented
Nov 5, 2024
Comment on lines
59
to
61
| await registry | ||
| .resolveSelect( coreStore ) | ||
| .getPostType( params.postType ); |
There was a problem hiding this comment.
We probably need to catch any potential errors here so they don't leak out as this function was previously not async.
|
@ndiego @colorful-tones @kevin940726 - I'd appreciate your feedback regarding my comment 🙏 |
Agreed. We also have a few additional items that have been punted 6.7.1, so ideally, we could get that release out by the end of the year. |
|
Most of the time This means there is a chance that on a slower connectiion, a user might click on a button and then sit around waiting for something to happen with no feedback whilst the request to resolve the post type happens. This probably isn't great. The only other choice seems to be to resolve all post types in advance in the Post Editor. |
IMO, that is normal behavior on the web when navigating to a different page. If you click a link on a website on a slow connection, you'll get the same behavior, right? |
Mamaduka
reviewed
Nov 14, 2024
Comment on lines
+61
to
+63
| await registry | ||
| .resolveSelect( coreStore ) | ||
| .getPostType( params.postType ); |
There was a problem hiding this comment.
@getdave, can you explain why we need to pre-resolve this selector?
There was a problem hiding this comment.
Yes it would help. Let me see if I can dig this up. We should include information inline in a comment.
There was a problem hiding this comment.
I think this is probably fixing a symptom rather than fixing the root issue where we may be using an undefined postType object or something.
I take your point but with standard hyperlinks the browser provides feedback that something is happening. You know the page was requested the browser shows UI to advise "I'm loading the new page". With the example I cited the UI will provide no feedback whatsoever. Rather the button will be clicked and then it will appear as though nothing is happening. |
|
This was always just a hotfix. Ultimately we can find a more holistic solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves error when programmatically navigating to a custom post type in the Post Editor.
Fixes #64814
Why?
Some additional context and discussion:
How?
Ensures all post types are loaded in the Post Editor before dispatching the request to navigate to that post type.
We load "on demand" to avoid performance overhead of loading all post types in the Post Editor.
Testing Instructions
wp/6.7there will be an error in the consoleTesting Instructions for Keyboard
Screenshots or screencast