Hide metaboxes in Zoom Out #66742
Merged
Hide metaboxes in Zoom Out #66742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
draganescu,
colorful-tones,
MaggieCabrera,
ndiego,
kevin940726,
stokesman and
t-hamano
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
added
[Type] Bug
kevin940726
approved these changes
Nov 5, 2024
|
Size Change: +24 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Nov 5, 2024
|
I'm away from my desk right now so I can't test it, but the code looks good to me. |
|
Flaky tests detected in 2141c8c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11681867153
|
|
I ended up force merging this one. The React Native tests passed but something in the process stops the test completing. Here's screenshot to confirm: 
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides metaboxes in Zoom Out mode.
Closes #66718
Why?
Meta boxes don't belong in Zoom Out which is designed for composing content.
How?
Conditionalise based on Zoom Out state.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-11-05.at.10-04-37.mp4