-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TS types for editor package #66754
Fix TS types for editor package #66754
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This change seems fine to me. It looks like we need to run |
It was |
Co-authored-by: manzoorwanijk <[email protected]> Co-authored-by: youknowriad <[email protected]>
What?
This PR fixes TS types for editor package.
Why?
Currentl, the types for the package are broken because of the third-party types package -
@types/wordpress__editor
, which we can deprecate following this PR.How?
The problem with types was that the
store
object exported by the package was typed asobject
, which prevented the type generator from setting the types correctly. Thus this PR removes that type annotation to allow inference from importsTesting Instructions
useSelect
anduseDispatch
are broken and TS yells that the selector is not callable or the method doesn't exist. You can verify that things will work fine without the third-party typesTesting Instructions for Keyboard
Screenshots or screencast