-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToggleGroupControl: Fix active background for zero
value
#66855
ToggleGroupControl: Fix active background for zero
value
#66855
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
zero
value
Flaky tests detected in 82336b3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11737501169
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
82336b3
to
0fc0998
Compare
What?
Discovered while working on #66837.
ToggleGroupControl had a logic error that would affect the background of the active item, if its value was zero. Zero is a valid value for this component so this PR just fixes that.
Testing Instructions
ToggleGroupControl
withToggleGroupControlOption
havingzero
value