Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboboxControl : Deprecate 36px default size #66900

Merged
merged 3 commits into from
Nov 19, 2024
Merged

ComboboxControl : Deprecate 36px default size #66900

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b1188c
Add the console warning for 36px size variation
PARTHVATALIYA Nov 11, 2024
3d9efb6
Add the changelog for the deprecation
PARTHVATALIYA Nov 11, 2024
16bafab
Update: changelog and JSDoc
parthVataliya16 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

- `BorderBoxControl`: Deprecate 36px default size ([#65752](https://github.com/WordPress/gutenberg/pull/65752)).
- `BorderControl`: Deprecate 36px default size ([#65755](https://github.com/WordPress/gutenberg/pull/65755)).
- `ComboboxControl`: Deprecate 36px default size ([#66900](https://github.com/WordPress/gutenberg/pull/66900)).
PARTHVATALIYA marked this conversation as resolved.
Show resolved Hide resolved

### Bug Fixes

Expand Down
1 change: 1 addition & 0 deletions packages/components/src/combobox-control/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ function MyComboboxControl() {
const [ filteredOptions, setFilteredOptions ] = useState( options );
return (
<ComboboxControl
__next40pxDefaultSize
PARTHVATALIYA marked this conversation as resolved.
Show resolved Hide resolved
__nextHasNoMarginBottom
label="Font Size"
value={ fontSize }
Expand Down
7 changes: 7 additions & 0 deletions packages/components/src/combobox-control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import type { ComboboxControlOption, ComboboxControlProps } from './types';
import type { TokenInputProps } from '../form-token-field/types';
import { useDeprecated36pxDefaultSizeProp } from '../utils/use-deprecated-props';
import { withIgnoreIMEEvents } from '../utils/with-ignore-ime-events';
import { maybeWarnDeprecated36pxSize } from '../utils/deprecated-36px-size';

const noop = () => {};

Expand Down Expand Up @@ -313,6 +314,12 @@ function ComboboxControl( props: ComboboxControlProps ) {
}
}, [ matchingSuggestions, isExpanded ] );

maybeWarnDeprecated36pxSize( {
componentName: 'ComboboxControl',
__next40pxDefaultSize,
size: undefined,
} );

// Disable reason: There is no appropriate role which describes the
// input container intended accessible usability.
// TODO: Refactor click detection to use blur to stop propagation.
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/combobox-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ const Template: StoryFn< typeof ComboboxControl > = ( {
};
export const Default = Template.bind( {} );
Default.args = {
__next40pxDefaultSize: true,
__nextHasNoMarginBottom: true,
allowReset: false,
label: 'Select a country',
Expand Down
8 changes: 7 additions & 1 deletion packages/components/src/combobox-control/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,13 @@ const getOptionSearchString = ( option: ComboboxControlOption ) =>
option.label.substring( 0, 11 );

const ComboboxControl = ( props: ComboboxControlProps ) => {
return <_ComboboxControl { ...props } __nextHasNoMarginBottom />;
return (
<_ComboboxControl
{ ...props }
__next40pxDefaultSize
__nextHasNoMarginBottom
/>
);
};

const ControlledComboboxControl = ( {
Expand Down
Loading