Site Editor: Avoid using edited entity state in site editor loading hook #66924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Nov 12, 2024
| const MAX_LOADING_TIME = 10000; // 10 seconds | ||
|
|
||
| export function useIsSiteEditorLoading() { | ||
| const { isLoaded: hasLoadedPost } = useEditedEntityRecord(); |
There was a problem hiding this comment.
my thinking is that this is a resolver as well, so there's no need to add this specifically here.
There was a problem hiding this comment.
This makes sense. I added a conditional breakpoint though and sometimes hasLoadedPost = false and loaded = true.
Visually though I couldn't spot something different and I also tried with throttling the network speed.
There was a problem hiding this comment.
This makes sense. I added a conditional breakpoint though and sometimes hasLoadedPost = false and loaded = true.
Was this during the initial loading or when you navigated between the pages? Seems the latter right and in that case it seems that it's probably ok.
There was a problem hiding this comment.
The latter. Yeah, I think it will be fine.
|
Size Change: -10 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/refactor-initial-loading
branch
from
6e5c6e0 to
3f90276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #66921
What?
As the site editor is growing to become a multi page app, it doesn't really make sense to have an edited post type and context state in it.
That state is forcing us today to have a two synchronization mechanism between the url and the state causing some issues related to performance and some hidden bugs at times.
Ideally the routes would just pass the post type, post id to the editor component. The current PR helps to go in that direction by removing getEditedPostType usage from the isLoading hook.
Testing Instructions