Post fields: move status from edit-site to fields
#66937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I've noticed the rendered status in the QuickEdit is lowercase: that happens in The reason for that is that we are defining a combined field that just renders the value (see). @louwie17 is looking at refactoring how combined fields work in DataForm at #66531 so I'll leave this as it is in this PR. |
|
Size Change: +2 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
oandregal
requested review from
youknowriad,
gigitux,
louwie17,
mcsf and
ntsekouras
oandregal
added
[Type] Enhancement
youknowriad
approved these changes
Nov 12, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…Press#66937) Co-authored-by: oandregal <[email protected]> Co-authored-by: youknowriad <[email protected]>
priethor
added
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #61084
What?
This PR moves the
statusfield definition fromedit-siteto thefieldspackage.Why?
In preparation for moving the whole
usePostFieldshook (conversation).How?
e869439
Testing Instructions
Visit the Pages page and verify that the "Status" field still works as expected (filters, visualization, edit).