WP Scripts: Revert changes that inline CSS imports early in the build process #66975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Regression
This was referenced Nov 13, 2024
|
Size Change: 0 B Total Size: 1.82 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
fix/wp-scripts-remove-postcss-import
branch
2 times, most recently
from
19bb6b6 to
217160c
Compare
gziolo
force-pushed
the
fix/wp-scripts-remove-postcss-import
branch
from
217160c to
faba9a7
Compare
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
added a commit
that referenced
this pull request
Nov 18, 2024
… process (#66975) * WP Scripts: Revert changes that inline CSS imports early in the build process * Fix changelog entry Co-authored-by: gziolo <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: benoitchantre <[email protected]> Co-authored-by: loxK <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66503.
Reverts #61121.
Why?
Import CSS files before the minification process doesn't work well with files imported from external dependencies located in
node_modulesfolder.How?
Reverts #61121.
Testing instructions
Step-by-step reproduction instructions
npmdependenciesbuild :
npm run buildnotice the errors importing the font referenced in the felxslider module :
# ls assets/blocks/fonts flexslider-icon.0c4bb125.eot flexslider-icon.b5aefbb7.woff flexslider-icon.c6c9e9e5.ttf