Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-data] Document and add types for dynamic actions and selectors. #66997

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Nov 14, 2024

Fixes #56287
Related #67142

What?

Define the type declarations for dynamic selectors and actions for core-data package`

Why?

The dynamic selectors cause errors when used in TypeScript because TS can't find those defined anywhere.

How?

The PR creates TS definition declarations for all the dynamic selectors and some useful actions

Testing Instructions

  • Use the dynamic selectors or actions in TypeScript files
  • Confirm that TS doesn't show an error

Example

import { store as coreStore } from '@wordpress/core-data';
import { select } from '@wordpress/data';

const { getUser, getUsers } = select( coreStore );

Testing Instructions for Keyboard

Screenshots or screencast

image

We will now have auto-completions for entity selectors
image

Copy link

github-actions bot commented Nov 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <[email protected]>
Co-authored-by: sirreal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment on lines +10 to +14
export interface PostType< C extends Context > {
/**
* All capabilities used by the post type.
*/
capabilities: Record< string, string >;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of these fields is copied from core REST API schema.

@gziolo
Copy link
Member

gziolo commented Dec 6, 2024

Moved to #67668.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Core data /packages/core-data [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core Data: Add TypeScript types for all the various entities
3 participants