Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add styling for selected links #670

Merged
merged 1 commit into from
May 5, 2017
Merged

Add styling for selected links #670

merged 1 commit into from
May 5, 2017

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented May 5, 2017

See #620.

@ellatrix ellatrix requested a review from jasmussen May 5, 2017 08:31
@youknowriad
Copy link
Contributor

youknowriad commented May 5, 2017 •
edited
Loading

It looks like TinyMCE is not adding this attribute to empty links.

@ellatrix
Copy link
Member Author

ellatrix commented May 5, 2017

It also does not remove the attribute on blur.

youknowriad
youknowriad approved these changes May 5, 2017
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I'm ok if we tackle the empty link issues separately

@ellatrix ellatrix merged commit f075d53 into master May 5, 2017
@mtias mtias deleted the add/link-selected-style branch May 5, 2017 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellatrix @youknowriad