-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: Fix focus loss when removing all filters or resetting #67003
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 3c4c6bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11837588090
|
I'm seeing that probably something has changed in the 'Patterns' list where, at least for me, the filters panel is initially open and thus focusing on |
What?
Fixes: #64697
In DataViews when we remove the last visible filter or resetting the filters the focus is lost.
This PR fixes that by focusing the
add filter
toggle when we do the above. I'm reusing the same Button for the filters toggle to have the sameref
, because based on the visible filters we either render anadd filter
button or a toggle visibility of current filters one.Testing Instructions
add filter
button