Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Pre-Publish Panel from Displaying Incorrect Information After Navigating away #67010

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Prevent Pre-Publish Panel from Displaying Incorrect Information After Navigating away #67010

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58c9b25
fix: close prepublish panel when navigating to edit a template part
sarthaknagoshe2002 Nov 14, 2024
73778d6
Merge branch 'WordPress:trunk' into fix/issue-64913
sarthaknagoshe2002 Nov 15, 2024
2657ddf
Merge branch 'WordPress:trunk' into fix/issue-64913
sarthaknagoshe2002 Nov 18, 2024
a8178e0
fix: use post ID comparison as a check to see if currentPostId is cha…
sarthaknagoshe2002 Nov 18, 2024
38fd027
fix: rename postId to currentPostId & used getCurrentPostId instead o…
sarthaknagoshe2002 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/editor/src/components/post-publish-panel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ export class PostPublishPanel extends Component {
// Automatically collapse the publish sidebar when a post
// is published and the user makes an edit.
if (
prevProps.isPublished &&
! this.props.isSaving &&
this.props.isDirty
( prevProps.isPublished &&
! this.props.isSaving &&
this.props.isDirty ) ||
! this.props.postlink
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better check would be to see if the currentPostId changed: this.props.currentPostId !== prevProps.currentPostId, where currentPostId is select(editorStore).getCurrentPostId().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ntsekouras, thanks for suggesting a better approach!
I have implemented the suggested changes, please have a look.

Thanks 🙌🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's use getCurrentPostId selector though instead of getEditedPostAttribute( 'id' ) and name the prop currentPostId for clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntsekouras I have implemented the changes!
Also, can you highlight on why using getCurrentPostId is a better approach?

Thanks 🙌🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Since we only want the id, getCurrentPostId returns that directly from the state whereas getEditedPostAttribute is a doing more and we don't need to fetch all the edits etc..

) {
this.props.onClose();
}
Expand Down Expand Up @@ -165,6 +166,7 @@ export default compose( [
} = select( editorStore );
const { isPublishSidebarEnabled } = select( editorStore );
const postType = getPostType( getEditedPostAttribute( 'type' ) );
const postlink = getEditedPostAttribute( 'link' );

return {
hasPublishAction:
Expand All @@ -177,6 +179,7 @@ export default compose( [
isSaving: isSavingPost() && ! isAutosavingPost(),
isSavingNonPostEntityChanges: isSavingNonPostEntityChanges(),
isScheduled: isCurrentPostScheduled(),
postlink,
};
} ),
withDispatch( ( dispatch, { isPublishSidebarEnabled } ) => {
Expand Down
Loading