Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu.ItemHelpText: better line breaking #67011

Merged
merged 6 commits into from
Nov 21, 2024
+2 −1
Merged

Menu.ItemHelpText: better line breaking #67011

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97951ac
Fix: Use break-word instead of break-all in attribute description
himanshupathak95 Nov 14, 2024
7c0d42e
CSS: Replace deprecated word-break with overflow-wrap
himanshupathak95 Nov 20, 2024
45245b7
Merge branch 'trunk' into fix/attribute-description-word-break-style
himanshupathak95 Nov 20, 2024
dfef21a
Docs: Add changelog entry for MenuItemHelpText text wrapping fix
himanshupathak95 Nov 20, 2024
f825315
Docs: Update changelog entry for Menu.ItemHelpText to internal section
himanshupathak95 Nov 21, 2024
b6424e3
Merge branch 'trunk' into fix/attribute-description-word-break-style
himanshupathak95 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- `ToggleGroupControl`: Fix active background for `0` value ([#66855](https://github.com/WordPress/gutenberg/pull/66855)).
- `SlotFill`: Fix a bug where a stale value of `fillProps` could be used ([#67000](https://github.com/WordPress/gutenberg/pull/67000)).
- `ColorPicker`: Add accessible label for copy button ([#67094](https://github.com/WordPress/gutenberg/pull/67094)).
- `MenuItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: adding a dot to represent the current component name

Suggested change
- `MenuItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).
- `Menu.ItemHelpText`: Fix text wrapping to prevent unintended word breaks by using `overflow-wrap: anywhere` ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nit, but I think that the ### Internal section would be more fitting for this CHANGELOG entry, given that the component is still a private API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ciampo, Thanks for the suggestions.

I have addressed all the feedback. Please let me know if there is anything else that can be done.


### Enhancements

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/menu/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export const MenuItemHelpText = styled( Truncate )`
font-size: ${ font( 'helpText.fontSize' ) };
line-height: 16px;
color: ${ LIGHTER_TEXT_COLOR };
word-break: break-all;
overflow-wrap: anywhere;

[data-active-item]:not( [data-focus-visible] )
*:not( ${ MenuPopoverInnerWrapper } )
Expand Down
Loading