Site Editor: remove redundant style-edit route #67057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Code Quality
ramonjd
requested review from
youknowriad,
oandregal,
tellthemachines and
aaronrobertshaw
|
Size Change: -17 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Nov 18, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added a commit
that referenced
this pull request
Dec 10, 2024
For top-level nav items without any child routes (styles) don't animate the sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? How and Why?
The styles site editor routes were introduced in this commit:
df3d341(#65619)However the route
matchcallbacks were the same for styles and edit: both of them matchedparams.canvas !== 'edit', effectively registered two routes for "view" mode.Give that the
/wp_global_stylesroute does not have any special layout in edit mode (or for edit + mobile) we can safely delete thestyles-editroute and fall back to home-edit.Props to @tellthemachines for noticing.
Testing Instructions
There should be no regression in the way the styles
/wp_global_stylesroute works in view and edit modes, either in "desktop" view (essentially wide screens) and "mobile" view (narrow screens)./wp-admin/site-editor.phpKapture.2024-11-18.at.15.13.39.mp4